This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Adds Ctrl-Click to Home Button #7881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsclifton
suggested changes
Mar 27, 2017
js/components/navigationBar.js
Outdated
| @@ -70,7 +70,11 @@ class NavigationBar extends ImmutableComponent { | |||
| contextMenus.onReloadContextMenu(target) | |||
| } | |||
|
|
|||
| onHome () { | |||
| onHome (e) { | |||
| if (e.ctrlKey) { | |||
There was a problem hiding this comment.
instead of e.ctrlKey, can you change this to use isForSecondaryAction() in eventUtil? Thanks 😄
jonathansampson
force-pushed
the
cmd-click-home-newtab
branch
from
db7667b to
d13a8f7
Compare
|
@bsclifton Ready for some fresh eyes on this :) |
…ab- this respects the home page setting Auditors: @jonathansampson
bsclifton
approved these changes
Apr 3, 2017
There was a problem hiding this comment.
@jonathansampson I updated the logic; ctrl/cmd + clicking was just opening a new tab (see GIF below- I do cmd + click and then do a regular click afterwards to show difference)
I updated the code to use the existing logic, except to also consider eventUtil.isForSecondaryAction
Tested with one and multiple homepages, works great 😄 ++
bsclifton
added
QA/test-plan-specified
release-notes/include
and removed
PR/work-in-progress ⚒
labels
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test Plan
Description
git rebase -ito squash commits (if needed).Fixes #7718